Skip to content

Extending error printing for silent wolfssl errors#268

Merged
aidangarske merged 2 commits into
wolfSSL:masterfrom
JeremiahM37:wolfprovErrorMsg
Sep 10, 2025
Merged

Extending error printing for silent wolfssl errors#268
aidangarske merged 2 commits into
wolfSSL:masterfrom
JeremiahM37:wolfprovErrorMsg

Conversation

@JeremiahM37

@JeremiahM37 JeremiahM37 commented Aug 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added WOLFPROV_MSG_DEBUG_RETCODE with the function name that is failing and the rc dump.

@JeremiahM37
JeremiahM37 force-pushed the wolfprovErrorMsg branch 2 times, most recently from f826e98 to 6f277c0 Compare August 28, 2025 22:06
@JeremiahM37 JeremiahM37 changed the title Extending error printing for silent wolfssl errors (WIP) Draft: Extending error printing for silent wolfssl errors Aug 29, 2025
@JeremiahM37
JeremiahM37 force-pushed the wolfprovErrorMsg branch 2 times, most recently from 3af9923 to 31b717a Compare August 29, 2025 16:54
aidangarske
aidangarske requested changes Aug 29, 2025
View reviewed changes
Comment thread src/wp_aes_aead.c Outdated
aidangarske
aidangarske reviewed Aug 29, 2025
View reviewed changes

@aidangarske aidangarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should find a place to mention that to see the rc from wolfssl you must add WP_LOG_DEBUG to the WOLFPROV_LOG_LEVEL_FILTER. Perhaps in wp_logging.h like in wolfProv_LogType

@JeremiahM37
JeremiahM37 marked this pull request as ready for review September 3, 2025 19:01
@JeremiahM37 JeremiahM37 changed the title Draft: Extending error printing for silent wolfssl errors Extending error printing for silent wolfssl errors Sep 3, 2025
@padelsbach

padelsbach commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

There are now 240 logs of the form WOLFPROV_MSG_DEBUG(WP_LOG_DEBUG, "foo() failed with rc=%d", rc);

Instead, we could add a function in wp_logging.c which unifies this for DRYness and code size. Eg:

void WOLFPROV_MSG_DEBUG_RETCODE(int component, const char* func_name)
{
    WOLFPROV_MSG_DEBUG(WP_LOG_DEBUG, "%s failed with rc=%d", func_name, rc);
}

padelsbach
padelsbach approved these changes Sep 10, 2025
View reviewed changes

@padelsbach padelsbach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@aidangarske
aidangarske merged commit 6e5b181 into wolfSSL:master Sep 10, 2025
446 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidangarske aidangarske aidangarske approved these changes
@padelsbach padelsbach padelsbach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeremiahM37 @padelsbach @aidangarske